This is my Solution for Testimonial webpage challenge

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @Bingolast, congratulations on your new solution!

  I’ve some suggestions for you:

  Something you can do is to improve your html markup using meaningful tags and replacing the divs. In this case, for example the main block/div that takes all the content can be wrapped with <main> or section, if you think about = the cards you can replace the <div> that’s wrapping each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Note that <div> is only a block element without meaning, prefer to use it for small blocks of content inside bigger blocks wrapped with some better markup.

  This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/testimonials-grid-section-vanilla-css-focus-effect-custom-design-e5bIzU3vZN

  ✌️ I hope this helps you and happy coding!

  0

  ---

  

  Parth Tiwari•50

  @BingolastPosted about 2 years ago

  @correlucas Thank you so much dude. I really was thinking how i can make my code more optimize thanks!

  0
• 

  Ahmed•400

  @AhmedLebdaPosted about 2 years ago

  Hi @Bingolast Congratulations on solving this challenge.

  You just need some modifications for your CSS file:

  1. You need to put your media queries at the end of your CSS files (after the main styles) because by putting them before your main styles you overwrite them again with the main styles that is the main reason your media styles don't work.

  2. Your .card:nth-of-type(3) have a grid-column: 4; you only want 1 column with 100% width but you tell the browser you want this card to be on the 4th column so the browser will translate this as if there were 4 columns even if you already defined the grid-template-columns: 1fr in the parent element, so by changing that to grid-column: 1; you will get your wanted result.

  • Worth mentioning resource : Kevin Powell video on CSS grid , he teaches grid easily with this same challenge example , I really recommend to watch it, you will definitely learn a lot from it.

  Happy Coding

  0

  ---

  

  Parth Tiwari•50

  @BingolastPosted about 2 years ago

  @AhmedLebda Thank you mate! i never thought of this. I tried so many things (literately banded my head on the desk almost breaking my keyboard) that was a huge help!

  0