Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

this is my real first try to use media query and it was a disaster

Zeyad Mohamedโ€ข 90

@ZeyadMohamed5


Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

for my first time using media query i think it wasn't that bad i just need to get to used to it and practice more

What specific areas of your project would you like help with?

i need some help with my media querys and i need another way to do the section between the footer and the "Your User" section because the way i did it wasnt practical at all

Community feedback

P
Koda๐Ÿ‘นโ€ข 3,830

@kodan96

Posted

hi there! ๐Ÿ‘‹๐Ÿ‘‹

Instead of adding margin to all the child elements you can just add padding to the parent container, and that will line up your text nicely.

Also it's a good idea to set margins and paddings using relative units (em, rem, ch, etc), since usually their size depends on the element's size (headings for example usually have their own font-size as margins above and below them, unless they are extremely large)

And I wouldn't use hard-coded values (pixels) for setting width or height.Actually don't even set them. Parent elements will always include child element's content by default, it's better to let the child elements determine the height of the parent, hard-coding heights can cause overflow.

Hope this was helpful ๐Ÿ™

Good luck and happy coding! ๐Ÿ’ช

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord