Design comparison
Community feedback
- @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to make the container center using flexbox or grid layout to make the container as per design Here's an example code snippet:
body { display: grid; place-items: center; min-height: 100vh; } now remove below lines of code .container1 { margin-top: 100px; }
Marked as helpful1@PASdecoPosted over 1 year ago@Kamlesh0007 is not working, please how can I message you directly?
0@Kamlesh0007Posted over 1 year ago@PASdeco bro why it is not working i have applied the same U can contact me through LinkedIn Or u can send the code that u have written
0 - Account deleted
Hello Coder🙂
your solution is great 🎉
But you used the wrong method to switch images and there are some better ways are available to handle the image switch problem
You can try <picture> tag to switch image
Picture tag :
<picture> <source media="(min-width: 597px)" srcset="./images/image-product-desktop.jpg "> <source media="(min-width: 0px)" srcset=" ./images/image-product-mobile.jpg"> <img src="./images/image-product-mobile.jpg" alt="Product_image"> </picture>
And I think you have a lot of doubt related to your solution that's why I recommend you to check out my solution✨ that will definitely going to help you 👀
I hope that will be helpful for you✌️
1@PASdecoPosted over 1 year ago@MrSandipSharma ok thanks alot, is fontawesome a better option for adding my icons?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord