This challenge is perfect if you're just getting started.

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hi Mohamed Khaled,

  Great work! Congratulation on completing this challenge. I have some suggestions regarding your solution if you don't mind:

  • About <h1>it is recommended not to have more than one h1 on the page . Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility.

  • You can add a <h1> with class="sr-only" (Hidden visually, but present for assistive tech).

  • In this challenge , the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" as you did and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images .

  What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  Aside these, Great job on this one.Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Mohamed Khaled•190

  @mohamedKhaled89Posted over 2 years ago

  @PhoenixDev22 Thanks a lot for your feedback.

  that's what I truly need

  • it is the first time to hear about the sr-only class
  • I used aria-hidden too.
  • I used a instead of button

  thanks a lot again for your help

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @mohamedKhaled89 Glad to help. Happy coding!

  1