Third project on frontend-mentor

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Excellent work

  Your solution looks great however I think that the following should be considered

  • The font family of the card does not match the font-family specified in the style-guide.md file

  • The divider line needs less opacity using opacity

  • The user avatar is missing a white border around

  In terms of your accessibility issues

  • the id attribute value must be unique which means that you can only use it one within your html markup

  • your html document is unable to identify the main content hence wrap all the tags within the body element within a main tag. It will resolve the issue because the main content will be identified.

  In terms of validation errors

  • Bad value fonts for attribute rel on element link: The string fonts is not a registered keyword. I think you intended to have this instead <link rel=`stylesheet` href=`https://fonts.google.com/specimen/Outfit`>

  • Bad value 30px for attribute width on element img: Expected a digit but saw p instead. This is because you specified the css unit px when you just needed to specify a value without any css units.

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  0