Third project: Mobile first site using HTML and CSS

Community feedback

• 

  Thiago Santos•295

  @thiago-hdsPosted about 3 years ago

  HI! It looks really great!

  Just two small things:

  • The "Calculator" and "Karma" cards are in different positions that they are on the design.
  • You could use the em unit for breakpoints to make the layout more flexible in case the user changes the browser default font size.

  Keep it up!

  Marked as helpful

  1
• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @zarkogolocorbin 👋🏻

  Your layout with grid looks excellent, However, I have some suggestions.

  • I just noticed that boxes for Calculator and Karma are swapped. Just fix grid-area and that should do the trick.
  • For the <img> tags, I'd suggest adding aria-hidden="true" because those images are for styling purposes only. You can read more about aria-hidden here

  I hope this was helpful 👨🏻‍💻 you did a great job, keep it up. Cheers 👾

  Marked as helpful

  1