ThePLANETS HTML / SASS / JS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Greetings, Yannis Haismann! 👋

  Good work on this challenge! 👍 It's good to hear that you're proud of your work and I hope you had fun building your solution! 😀

  I noticed that on some planet pages (such as Jupiter and Saturn), the magnifying glass that appears when clicking on the "Surface Geology" tab covers up some of the text in the tablet/mobile layout of the site. You might want to decrease the size of the images, then, to avoid this issue and also to make sure that none of the corners of the images are cutoff from not fitting within their container. 😉

  Keep coding (and happy coding, too)! 😁

  2

  ---

  

  Yannis Haismann•170

  @YannisHaismannPosted over 3 years ago

  Hey, first thanks for your support :)

  I have tried to get the same issue but in my navigator, images are getting the perfect size. So maybe need a refresh to have the great size of the pic ?

  Thanks for your feedback that's very helping :D

  (Sorry for my english)

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @YannisHaismann

  Glad to help! 😀

  Haha, I was typing something about the issue still being there, but a few page refreshes seemed to do the trick and the issue disappeared, for some reason. 👍

  BTW, don't worry—your English is fine! 😄

  3
• 

  joni•365

  @joni475Posted over 3 years ago

  You forget to apply for the mobile version.

  1

  ---

  

  Yannis Haismann•170

  @YannisHaismannPosted over 3 years ago

  No, I thought about it, maybe refresh page?

  0

  

  Yannis Haismann•170

  @YannisHaismannPosted over 3 years ago

  Nevermine you're right i will repost it on my GitHub, thanks for your feedback !

  0
• 

  Clément Creusat•1,655

  @ccreusatPosted over 3 years ago

  Nice one and it does the job! I would add a current/active link in the navigation according to the current planet :)

  1

  ---

  

  Yannis Haismann•170

  @YannisHaismannPosted over 3 years ago

  Oh i see what you are meaning, thanks for feedback :)

  1