Theme Switcher Social Dashboard was made with HTML5,CSS3 and JS

Community feedback

• 

  Roman Filenko•3,335

  @rfilenkoPosted over 4 years ago

  Hello, good job, but you can improve it. The problem is with your js solution of changing light/dark theme. You are injecting diff css which causes overflow. Proper way of doing the toggle - create one .css file (or sass with few imports). There define default, light theme colors (you can use custom properties) and also .dark-mode class( for appllying darkmode changes). With js just toggle this class, for example on body.

  Also noticed css issies:

  • overflow problem, disable width: 100vw on body and after pseudo el.
  • don't use just vw units for font-size - on bigger screens 1vw will be too small.

  Cheers, Roman

  0

  ---

  

  Edimário Júnior•155

  @EdimarioJrPosted over 4 years ago

  @rfilenko Thanks for the tips, man. I did a little research and find a better way to implement the theme switch thing,

  using css variables and classes, like you told.

  I disabled the width: 100vw and readapted my fonts.

  Cheers, Edimário.

  0