The simple card

Community feedback

• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 2 years ago

  Halo Fadll! Udah mantap solusinya!

  Cuman mau kasih tips. buat const allRating = document.querySelectorAll(".radio-input"); mending ditaruh di luar sama selector yang lain di atas. Kalo di dalem function nanti dia harus terus-terusan di lakuin ulang tiap klik.

  Semoga bisa bantu ya!

  1

  ---

  

  Muhammad Fadll•320

  @fadelunPosted over 2 years ago

  @fazzaamiarso baik kak mkasih masukannya

  0
• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Hello Muhammad Fadll!

  In terms of design I think you have a good responsive design as well as the design when you switch to the other card.

  On the issue of functionality I would recommend that when clicking on submit do not leave the default value of 4, rather if the user has not chosen any of the values do not allow him to give submit.

  Also I do not recommend to use section because you are creating a component at the end that is a card that can be reused, use section when you are going to include sections in your page not necessarily in separate components because you will get a lot of those errors in the report.

  If you can add the property transiton to the elements that use pseudoclasses like :hover, :active, :focus, etc. so that at the moment of activating a state the change is not so abrupt but rather that it is seen with certain delay for example: transition: color 200ms.

  1

  ---

  

  Muhammad Fadll•320

  @fadelunPosted over 2 years ago

  @Sdann26 Thank you for your feedback

  1