The multi-page entertainment app (React, Typescript, Redux-toolkit)

Community feedback

• 

  Matt West•440

  @matt-o-westPosted 10 months ago

  Thank you for submitting your code! Let me provide you with some feedback:

  • You need a max width on the scrollable bar (Trending section) at the top of the main page, right now it extends past the rest of the content in larger viewports, leading to a poor ux in those formats.
  • I believe in your reducers, you shouldn't need to perform immutable operations, as redux runs with immer. So, you shouldn't need to use the spread operator, you should just be able to change the property, push an item to an array etc. You don't have to use it like that, but it is a paradigm that makes redux useful and reducers boilerplate.
  • Your tailwind use is pretty good, if you want to get better you can check out free Youtube courses like this one from Dave Gray (https://www.youtube.com/watch?v=lCxcTsOHrjo), or check out the official docs, which are very comprehensive.
  • I would recommend binding demo credentials to your login, so people don't need to create a new account if they don't want to (save some clicks).

  This is a complex project, and a great solution, you should be proud!

  Marked as helpful

  1

  ---

  

  Maria Ushakova•150

  @Mariia22Posted 10 months ago

  @matt-o-west Thank you so much for your feedback. I greatly appreciate your advice, and I'll improve my project according to your recommendations.

  0