The base apparel landing page

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Hey Abdelrhman, nice work on this challenge. Here are a few pointers after taking a look at your code:

  • You've got set the main page heading as a paragraph, whereas a h1 would make more sense to create a basic content hierarchy.
  • Watch out for uppercasing content in the HTML itself. Try to avoid doing that as some screen reader software will read this content letter-by-letter which makes that content inaccessible to screen reader users. Instead, write it normally in your HTML and then use text-transform: uppercase; in your CSS to visually uppercase the text to match the design.
  • For the email input, I'd recommend wrapping it in a form and using a button instead of an anchor tag to submit the form. This would be a more typical structure to a form in HTML.

  I hope this helps. Keep up the great work!

  0