Design comparison
Solution retrospective
The functions used for the calculations was quite difficult for me but I was able to do it I don't know if what I did was right but I got the results. Also I don't know if my process used are of best practice. I added a reset function not part of the instructions though but I had to for more fun
Community feedback
- @DrZero1234Posted over 1 year ago
Hey!
First off congratulations your site looks pretty good you also did the bonus animation (i didnt have the patience). I fiddled around for a couple of minutes and noticed some issues
- Although the user gets error when entering invalid D M or Year the site calculates the result.The validation shouldnt just warn the user of invalid input it also should prevent them from calculating with them.
- After i generate a result and edit the input the user doesnt get the updated result the form resets instead without any result
- The text above the inputs should be <label> elements its much more accessible
Hopefully my feedback had some value.
Happy coding
1@Princecodes205Posted over 1 year agoThanks for your review boss I just fixed the error section of the page i didnt notice that anyways i didn't have the patience to do that and for updating number 2. if after calculations have been done the next click should reset the values so you can input a new value, it was not part of the functions but I had to do something different @DrZero1234
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord