the 3rd challenge and I see I know more and more...
Design comparison
Community feedback
- @JohnIdenyiPosted over 2 years ago
Nice work Pawel! But you have some accessibility issues.
- <p class="creation">Creation of <x>Jules Wyvern</x></p> "x" is not an html element so it shouldn't be used rather use <span> which is meant for inline elements.
-
Secondly, you should use semantic HTML elements like <main> or <section> to wrap contents in your document. So instead of this <div class="background"> you should do this <section class="background"></section>.
-
Thirdly, your webpage is not responsive on mobile device. Try using a media query to create styles that apply to mobile devices. You should try reducing the width of the container and the background class.
I hope this was helpful.
Marked as helpful0@RosinskiPawelPosted over 2 years ago@JohnIdenyi Hi John, thank you very much for your very helpful feedback. I appreciate it :-)
Have a nice day! Pawel
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord