That was first grid i have ever use that was really tricky to make it

Community feedback

• 

  Doston Nabotov•950

  @dostonnabotovPosted about 2 years ago

  Hi, there! That looks great! But, I found some problems, too.

  You don't specifically need to adjust the grid at 375px. If your phone is 400p, the UI doesn't look quite good. The preferred media query for most sites is 50em. So, you need to aim for that size. In the style-guide.md, it mentions how it should look at 375px.

  Wrapping all the text in one <p></p>, and giving each one <br> is considered a bad practice. Consider using <ul> and <li> to improve the accessibility of your site

  Furthermore, imagine this project grows in the future. As its name implies, it is a single-price-grid COMPONENT, which means that it will be used in other parts of the site as well. Thus, consider giving meaningful class names to your HTML elements. I recommend removing position: absolute from body in CSS. As the project grows, it will be much harder to maintain.

  Colors need to be adjusted according to the design.

  I hope it helps. Good luck!

  Marked as helpful

  0