That was easy :)

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Hussain754, Congratulations on completing this challenge!

  Unfortunately your live site is not previewing, due an error with the Github Pages I don’t recommend it since it's too hard to set up.

  If you really want to use Github Pages you can try to follow this guide to use it and fix the settings for your page https://docs.github.com/en/pages/quickstart.

  My suggestion it that you use vercel.com or netlify.com that are really easier platforms for live sets and totally user-friendly, in a matter of 5min your live site is online. All you need to do is to connect the Github account, import the repository and deploy it. Really fast.The easy one is Vercel and is the one I use for my solution.

  Fixing that you've to update the solution with the new link and we'll be able to see your live site and help you.

  ✌️ I hope this helps you and happy coding!

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Hussain, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the images
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • remove all margin from container class
  • use justify-content: center a flexbox property to the body to center the card horizontally
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  0