Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

testing Sass on QR code page

@MaracaraCarlos

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

Hello everyone, I took this challenge as part of the beginner learning path. I'm excited because I started using ✔️Sass and the result was very similar to the design provided by the Frontend Mentor team.

Community feedback

T
Chamu 13,110

@ChamuMutezva

Posted

Hi Carlos Maracara

Having gone through your project, here is some points to consider

  • instead of using <section role="main" class="container"> , html has the main element that should be used.
  • the image in my view carries an important message , therefore it should not be used as a background image . Preferably use img element with a description in the alt value
  • setting the body element in the css to height: 100vh; works , but for best practice instead use min-height: 100vh; - this does allow scrolling if the content does not fit
  • keep specificity as low as possible by simply appying styles to the target class. The following body .container .codigo-qr , is not necessary as that would cause maintenance and debugging problems especially in big projects. You can just use .codigo-qr
  • using fixed heights and widths in your container elements will cause responsive issues, for example
body .container {
  height: 500px;
  width: 320px;
  border-radius: 20px;
  background-color: #ffffff;
  padding: 15px;
}

For the above the height will cause content to be cut off , if it does not fit the container. Let the content decides the height by using the size of the content, paddings and margins where necessary. For width , using max-width to allow the container not to exceed a certain width instead of a fixed value. Also font sizes and these dimensions should be in rems not px, the following article Why font-size must NEVER be in pixels can help you understand the reasons behind the suggestion

Marked as helpful

0

@MaracaraCarlos

Posted

Hello @ChamuMutezva thank you for your response, it helped me a lot to reinforce the theory in CSS and HTML, and I also learned several interesting things in the article you sent.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord