testing frontend mentor

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 10 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change .card to a <main>.

  • The image should be located in your project files and loaded from there.

  • Alt text must also say where it leads (Frontend Mentor website).

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove overflow: hidden, it is not needed.

  • Remove all widths and heights.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • Add align-items: center on the card to center the content horizontally.

  • Remove all properties on .card-qr.

  • On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

  • To create the space between the image and the edge of the card, set padding on all 4 sides of the card.

  • font-size must never be in px. This is bad for accessibility, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  Marked as helpful

  0

  ---

  

  keyule•100

  @keyulePosted 10 months ago

  @Islandstone89 thanks

  1

  

  keyule•100

  @keyulePosted 9 months ago

  @Islandstone89 hi, if you have the time, would you give me some advice on my other solutions? thanks

  0