Design comparison
Solution retrospective
Feedback would be appreciated
Community feedback
- @Mosaab-EmamPosted almost 4 years ago
I like it, you almost got it perfect. Respect.
I have a few words about it to share, I hope that my feedback helps.
-
The first issue I noticed is that I cannot scroll. I tried with both my laptop and phone, so I guess you have a stray "overflow: hidden" in your code, on the body, maybe, so check that out.
-
The second design issue is that the white space between the cards is not equal. It is obvious that the white space separating the cards horizontally is significantly larger than that separating them vertically.
-
I noticed that on two cards you have a purple-ish ring around the people's photos, but the rest of the cards don't have that, so there is an issue of consistency.
-
Also, you need to pay more attention to contrasts, look at the phrase "Verified Graduate" on each of the cards. On some cards, the phrase is readable, a bit harder to read on others, and very hard to read on the white ones.
-
And finally, a minor issue, also related to white spacing, the person's name on each card is a little crammed to the subtitle below it "Verified Graduate" when there is a decent amount of spacing between the title and the main body text. So improve your design even more by giving the person's name a little bit of "padding-bottom".
That will be all, I wish you lots of luck.
4 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord