testimonials-grid-section-main : first time trying a Junior Challenge

Community feedback

• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Soyto, great job finishing the challenge, you almost got it pixel perfect holy!

  Apart from what Lucas said wich is completely correct, you could play more with the headings, instead of using such low levels heading (try using more h2, h3, you can use mutiple of those with no penalization!).

  Good job with the semantics overall, probably wrapping all your content on a main tag could be a good idea to avoid the frontendmentor main validation.

  Also would recommend you to use a name methodology as BEM, with this your classes will get much more oganized and it will be much easy for you and other developers to read you CSS code.

  Hope my feedback helps you, great job!

  Marked as helpful

  0

  ---

  

  Soytto•180

  @SoyttoPosted about 2 years ago

  @DavidMorgade Thank you so much ! It will definitely help me a lot !

  I don't know the BEM methodology at all, I'll find out about all that now.

  Thanks again !!

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  Hello Soyto, congratulations for your solution!

  I think you've done a really good work here putting everything together, this is a hard challenge and every detail is fine. Something you can change is to add at least one h1 heading and increase the others by one level a time and replace the paragraph containing the quote text with <blockquote>.

  Hope this helps, happy coding!

  Marked as helpful

  0

  ---

  

  Soytto•180

  @SoyttoPosted about 2 years ago

  @correlucas Thank you for your feedback !

  I will try to use the headings better than that i did. I didn't know about <blockquote> but I will use it for sure next time !

  Thank you again, it was really useful !

  0