testimonials-grid-section-main

Community feedback

• 

  John_diddles•470

  @JohndiddlesPosted over 2 years ago

  Hi Mahmoud! I really love your solution. You did really good with this.

  I see you gave your grid items some margin to space out the items, it is a better practice to use gap instead of margin just like this;

  .container {
    display: grid;
    gap: 20px;
  }
  

  This will evenly space out all the items in the grid by 20px both vertically and horizontally and you won't be needing the margins.

  Also you can consider using other size units (such as em) for your texts instead of 'px'. I also see you have the same text color for all your p tags, but I think according to the designs, the colors are meant to be different. The white backgrounds have darker texts while the other ones have much lighter texts.

  Overall, you did a solid solid job. Cheers 🍻

  Marked as helpful

  1

  ---

  

  Mahmoud ELshora•40

  @elshoraPosted over 2 years ago

  @Johndiddles cheers mate.

  Those are very helpful notes, thank you very much. I work on it.

  0