Design comparison
Solution retrospective
Hello everyone! this is very easy task so please give your suggestion for my coding skill and how to improve! thank you.
Community feedback
- @zineb-BouPosted almost 3 years ago
Hi there
Some suggestions that may help you to improve your code even further
-
Give the image an explicit width and height along with using object-fit property to keep the image look consistent when scaling down to different screen sizes, avoid using
overflow: hidden
it's clipping the image content. -
The illustration image is not centered horizontally on the mobile screen.
-
Instead of wrapping the question inside the button, give it the right HTML markup, for instance, you can use <h3> ( the <h2> should be used for the card title and <h1> for the page title), give the button a meaningful text that describes exactly what it does(toggle arrow button), then hide the text visually since there is no text provided in the design.
-You are submitting a solution for a completely different challenge.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord