testimonials-grid-section

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace div class="container"> with the main tag to make the page/content accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .container on the page using flexbox or grid instead of margin:

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  For a responsive content, give .container a width of 80vw or a max-width of 1440px and a width of 80% instead of a margin , height and padding value .

  There is no need to give .container grid-auto-rows, align-items: center and justify-content: center.

  You forgot to add a media query for the mobile design. For more on media queries, click here

  I will advice you always begin with the mobile design first , this will make the process a little bit easier.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Yabesh•180

  @YabeshyjPosted over 1 year ago

  Hey @Rayan4r your solution is nice, keep try to learn css grid as well so you can design it very well,

  Here some Tips to avoid warnings ⚠️

  1)use at least one heading<h1> tag in your html file 2)wrap all the HTML content in <main> tag so u can't get landmark warnings 3)use alt attributes in img tags

  Marked as helpful

  0