testimonials-grid-section using HTML, sass/scss

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted almost 3 years ago

  👋 Greetings, Isaac!

  🎉 Congratulations on finishing this challenge! 🙌 Your solution looks good and responsive. Also, in my opinion, you are using the correct semantic HTML which is awesome 👍.

  I have two feedback:

  • Every page should only contain one h1, so in this case, you make all the h1 as h2 instead. h1 is used as a unique identifier of each page, that's why it is a good thing to have only one h1 for each page.
  • It's a good thing that you are using rem unit instead of px, but changing the html or root font size can cause huge accessibility implications for those of the users with different font size or zoom requirements. Read what an accessibility expert (Grace Snow) has said about it.

  That's it! Keep it up and hopefully, this is helpful!

  Marked as helpful

  1

  ---

  

  Isaac•140

  @agaushaPosted almost 3 years ago

  @vanzasetia well noted; thank you very much for your feedback.

  0
• 

  abdulrahman badamasi•460

  @papilo-cloudPosted almost 3 years ago

  Its nice, but the texts are not placed at the center

  0

  ---

  

  Isaac•140

  @agaushaPosted almost 3 years ago

  @papilo-cloud Okay, thank you.

  0