Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

testimonials-grid-section using HTML, sass/scss

Isaacā€¢ 140

@agausha

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback will be appreciated, happy coding...

Community feedback

Vanza Setiaā€¢ 27,795

@vanzasetia

Posted

šŸ‘‹ Greetings, Isaac!

šŸŽ‰ Congratulations on finishing this challenge! šŸ™Œ Your solution looks good and responsive. Also, in my opinion, you are using the correct semantic HTML which is awesome šŸ‘.

I have two feedback:

  • Every page should only contain one h1, so in this case, you make all the h1 as h2 instead. h1 is used as a unique identifier of each page, that's why it is a good thing to have only one h1 for each page.
  • It's a good thing that you are using rem unit instead of px, but changing the html or root font size can cause huge accessibility implications for those of the users with different font size or zoom requirements. Read what an accessibility expert (Grace Snow) has said about it.

That's it! Keep it up and hopefully, this is helpful!

Marked as helpful

1

Isaacā€¢ 140

@agausha

Posted

@vanzasetia well noted; thank you very much for your feedback.

0

@papilo-cloud

Posted

Its nice, but the texts are not placed at the center

0

Isaacā€¢ 140

@agausha

Posted

@papilo-cloud Okay, thank you.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord