Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello MaxSurawut, congratulations on your new solution!
Something you can do is to improve your html markup using meaningful tags and replacing the divs. In this case, for example the main block/div that takes all the content can be wrapped with
<main>
or section, if you think about = the cards you can replace the<div>
that’s wrapping each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that<div>
is only a block element without meaning, prefer to use it for small blocks of content inside bigger blocks wrapped with some better markup.Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp
✌️ I hope this helps you and happy coding!
0@MaxSurawutPosted about 2 years ago@correlucas Thank for your advice I'll use it on next project Cheers
0 - @HawigirmachewPosted about 2 years ago
Hello, @MaxSurawut congratulation for completing this challenge. Your solution is excellent, and I learnt a lot from it, however I believe it would be better if you used semantic tags for it, such as main, section, and footer, as well as heading tags. I hope this will be useful to you.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord