Testimonials-Grid-Section

Community feedback

• 

  César Mejias•190

  @CesarGMEFAPosted about 3 years ago

  Hi! I want to tell you that you can apply this to the rem measure. html { font-size: 62.5%; } In this way 1rem would be the same at 10px. so 1.8rem is 18px, 3rem is 30px.

  the size of the browser is 16px and if you pass that code it is 10px.

  0
• 

  T

  Grace•31,270

  @grace-snowPosted over 3 years ago

  Hello!

  Well done it all looks fixed on mobile now, and it looks like you've added the missing alt attributes to sort the errors in the report.

  The only remaining issues I see are

  • inline styles in the html that should be in css
  • lack of semantic html. Text should never be in a div or span alone. You need to choose semantically meaningful elements for all items holding text. E.g. Heading for name, paragraph with small tag inside for verified, two paragraphs for the quotes, something like that
  • font size in the css is in pixels, but you should never put in pixels or it will not scale properly for some people. Use rem instead (eg for 15px, divide 15 by 16 to get the rem value, which is 0.9375rem)

  I hope that helps ☺

  0

  ---

  

  prakash•250

  @mewebbiePosted over 3 years ago

  @grace-snow Those are some great points to work on. Thanks a lot.

  0
• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  Hi, good job, it look nice and responds well. Some things that you can improve are:

  1. Try to avoid writing inline styles bacause in unneccesary and you can accomplish the same thing without them but if you using a framework that's a different case.

  2. Around 1000px everthing looks a bit squashed, you can fix this by creating a tablet view, a modification that helps a litle bit is reducing the horisontal margin the top-most at this size.

  3. The way you've written you markup is totally fine and functional but there are better alternatives for some parts, for example article-middle can be a p tag and article juice should be contained in a blockqoute or a p.

  Keep coding :)

  0

  ---

  

  prakash•250

  @mewebbiePosted over 3 years ago

  @MojtabaMosavi Ya mate. Noting down all of it. Thanks a lot.

  0