TESTIMONIALS-GRID-SECTION

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Mamadou, congratulations for your new solution!

  Here's some tips to improve your solution:

  Your html is working but you can improve it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with <main> or section, about the cards you can replace the <div> that wraps each card with <article> you can wrap the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  SEMANTIC TAGS: Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp

  The shadow you've used it's a it too dark, you can improve it decreasing the opacity. The correct value for this shadow is box-shadow: 5px 5px 15px 5px rgb(0 0 0 / 3%);`

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  David•8,000

  @DavidMorgadePosted about 2 years ago

  Hello Mamadou congrats on finishing the challenge!, your layout looks full responsive in diferent sizes! good work on that

  The only thing that is missing in your solution is the having all the testimonial on the middle of the screen, it seems that you already used flex-box to try to align everything in the middle but is still missing a vertically center, if you want to archive it, you just need to give to your body a min-height: 100vh, with this your body will wrap the whole screen of any device, and it will center the testimonials vertically too!

  I also like to add that I like a lot the effect that you added to the testimonials! haha

  Hope my feedback helps you! good job!

  Marked as helpful

  0