Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

testimonials-grid using css grid, scss , scss @for loop

Priya Nayakβ€’ 130

@priya180975

Desktop design screenshot for the Testimonials grid section coding challenge

This is a solution for...

  • HTML
  • CSS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


any feedback is appreciated

Community feedback

Lucas πŸ‘Ύβ€’ 104,420

@correlucas

Posted

πŸ‘ΎHello Priya, congratulations for your new solution!

To make this alignment, first of all put min-height: 100vh to the body to make the body display 100% of the viewport height (this makes the container align to the height size thats now 100% of the screen height) size and display: flex e flex-direction: column to align the child element (the container) vertically using the body as reference.

body {
    min-height: 100vh;
    background: #cfcfcf;
    display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
}

Improve the grid semantics it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with the tag <main> or section, about the cards you can replace the <div> that wraps each card with <article> and the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

πŸ‘‹ I hope this helps you and happy coding!

Marked as helpful

0

Priya Nayakβ€’ 130

@priya180975

Posted

@correlucas Thank you so much for the feedback . I will work on it and improve the solution.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord