testimonials-grid using css grid, scss , scss @for loop

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Priya, congratulations for your new solution!

  To make this alignment, first of all put min-height: 100vh to the body to make the body display 100% of the viewport height (this makes the container align to the height size thats now 100% of the screen height) size and display: flex e flex-direction: column to align the child element (the container) vertically using the body as reference.

  body {
      min-height: 100vh;
      background: #cfcfcf;
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
  }
  

  Improve the grid semantics it using meaningful tags and replace the divs, for example the main div that takes all the content can be wrapped with the tag <main> or section, about the cards you can replace the <div> that wraps each card with <article> and the paragraph with the quote with the tag <blockquote> this way you'll wrap each block of element with the best tag in this situation. Pay attention that <div> is only a block element without meaning.

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Priya Nayak•130

  @priya180975Posted about 2 years ago

  @correlucas Thank you so much for the feedback . I will work on it and improve the solution.

  0