Testimonials-grid Solution

Community feedback

• 

  Sicro01•60

  @Sicro01Posted over 1 year ago

  Hi,

  Looks good - only one suggestion....

  If you view the site on a much larger screen size there is no constraint on the width of the cards. Not a big issue for this site but it you wanted to experiment you can achieve this by changing your "grid-template-columns" statement:

  From: grid-template-columns: repeat(4, 1fr);

  To: grid-template-columns: repeat(4, minmax(smallest size, largest size));

  Replace the smallest/largest with whatever works; you can also adjust the repeat aspect if different column need different sizes. The "largest size" sets the max width of the column.

  One further tip - you could set the sizes using a CSS variable, defined say in your root (as you've done with your font) and play around with the numbers there.

  Good luck!

  0

  ---

  

  Giulia•210

  @GiuliaT97Posted over 1 year ago

  It is true! I forgot to set a max-width.... I'll use the method you suggested, thanks.@Sicro01

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="grid-container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Giulia•210

  @GiuliaT97Posted over 1 year ago

  Thanks, I will pay more attention with the next challenges!@0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @GiuliaT97 Glad you found it helpful ! 🤠

  0