Design comparison
Solution retrospective
Hii, i done one more project!
This one was a nice refresh from all those frameworks i've been with, and a great opportunity to learn how to write better css as my previous ones was a mess haha
Anyway, Hope you liked it <3 and as aways, please roast me >:D I love to receive some critics, anything and everything you think is horrible or wrong, please let me know!
Community feedback
- @elaineleungPosted about 2 years ago
Hi Lucas, this was really well done, and I love that gradient background! I also like the way you structured your HTML with the use of semantic tags, and it reminds me that I need to go back and rewrite my HTML. At first I couldn't really tell that you had the box-shadow on your cards until I saw it in the inspector, and removing it does show a difference even though the values you used make it pretty subtle (I might use a smaller blur radius), but I think the subtlety works!
I wasn't planning to get any suggestions or advice since there really isn't any, so I guess the only thing is to remind you about the accessibility issues in your report, especially the
main
tag! Great job once again 🙂Marked as helpful2 - @correlucasPosted about 2 years ago
👾Fala Lucas Matheus, tudo bem? Parabéns pelo desafio!
Outra solução perfeita, gostei mto das cores. Duas coisas que você poderia fazer pra melhorar é colocar a transição nos dois estados de hover pra ficar mais suave, no estado inativo e ativo pra fazer o efeito loop de crescer e diminuir com
transition: ease-in 0.5s
pro hover etransition: ease-out 0.5s
pro estado inativo.E usar
<blockquote>
no paragrafo com a citação substituindo op
, pra melhorar a acessilidade marcando exatamente o que tem dentro daquele bloco de conteudo.👋 Espero ter ajudado e continue no foco!
Marked as helpful1@LukiticasPosted about 2 years ago@correlucas Olá Chef! Obrigadão pelas dicas, eu realmente estava tendo um pouco de dificuldade de entender o pq das minhas animações não estarem sendo aplicadas em ambos os "lados", mas consegui dar uma volta nisso colocando o
transition: transform 500ms ease
e umtransform: scale(1)
pro pai, e apenas otransform: scale(1.08)
pro :hover. Será q adicionando as animações em ambos como mencionaste é melhor?0@correlucasPosted about 2 years ago@Lukiticas eu sempre coloco nos dois, tem alguns elementos que funciona colocando no pai com
transition: all ease 0.5s
o all faz pegar nos dois elementos, mas eu não sei o motivo de funcionar algumas vezes e outrasnao, dai coloco sempre nos dois, 😂1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord