Testimonials using grid and css

Community feedback

• 

  P

  rmmcfarlin•190

  @rmmcfarlinPosted 2 months ago

  Your solution is spot on, your code is well structured and easy to read.

  As far as using selectors to format each of the cards, what is wrong with assigning each their own id instead of using pseudo selectors? I am a beginner so I might be wrong here, but for me it would seem easier to just assign each card an id (ex. id="card1"), instead of using combinations of pseudo selectors. Unless there is some disadvantage that I am unaware of, this seems like it is more efficient and avoids over-specificity.

  Also, it seems to me like the breakpoint might be set at too large a width. It might be advisable to make your layout responsive enough to shrink down to a more common breakpoint (i.e. 48rem / 768px), or set another "medium" grid layout to avoid having the column layout take effect with larger viewports. This is just my impression though. It's still responsive, but to me the column format doesn't look good at larger viewport widths.

  Overall though this solution is spot on to the design, excellent job.

  1
• 

  P

  Pokerlo442•230

  @Pokerlo442Posted 2 months ago

  Thanks for the kind words! I used pseudo selectors for the task for practice purposes. For real projects, I would definitely prefer to use classes or id's. These are easier to read for subsequent programmers. You are absolutely right about the breakpoint, it would be better to include an intermediate stop for tablet users. I just wanted to follow the instructions in the project and only Desktop and Mobile view were integrated there.

  0