Design comparison
SolutionDesign
Solution retrospective
-
Should I use rem units everywhere for responsiveness?
-
Do you always comment your code?
Community feedback
- @RabberpoliPosted over 1 year ago
Hi, Well done for doing this challenge! The final result is great!
Back at your questions:
- Using
em
orrem
would be better than using justpx
. That's becausepx
will be the same size for every screen resolution; this could be a problem in term of accessibility and responsiveness. So: yes, best practice suggestsem
orrem
. You can read more here - Talking about commenting code: I usually comment code that it would be hard to understand if I read it after long long time. I would avoid to comment every single line and usually is best practice to write code that explains itself without the need of commenting every line.
Hoping to be helpful, keep going and happy coding!
Marked as helpful1 - Using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord