Testimonials slider master

Community feedback

• 

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  Hi @0hyodorie0 some great work here. Yes the background and slider positions are tricky on this one. Some suggestions to consider for this challenge:

  1. I would remove the margin-left that you have on the button hover state. This moves the button out from under my cursor and it's a bit off putting. I don't think you need it?

  2. Small point, but where you have the class spoke you could try using the html block quote tag with a p inside it instead - I think it's nice to get used to using the different tags where we can.

  3. Lastly, at small viewport sizes the content is no longer centered. You can address this by setting grid or flex on the body with the appropriate properties, or wrapping everything in a div and setting these values on that.

  There are a few different ways to go about this, and it's worth finding one that works for you. I do this in pretty much every challenge to make sure things are centered properly. Let me know if you need any more info on this and I can share what I do.

  And great work on the background images they look great to me! Keep up the great work.

  Cheers!

  1

  ---

  

  Sondra Sohn•90

  @0hyodorie0Posted over 3 years ago

  @dwhenson Thank you so much ! I should practice set contents centered in all viewport! it helped me a lot!

  0