Design comparison
Solution retrospective
Any edits or comments to better my page will be much appreciated.
Community feedback
- @LeskimPosted about 2 years ago
You can try fixing the accesibility issues and give a bit of padding to the bottom paragraph to get a bit of separation from the top one
Marked as helpful2 - @kibiwotkosgeiPosted about 2 years ago
Great work Collins Kibenon! Welcome to frontendmentor.
Marked as helpful2 - @correlucasPosted about 2 years ago
👾Hello @collinskibenon, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
Something you can do is to improve your html markup using meaningful tags and replacing the divs. In this case, for example the main block/div that takes all the content can be wrapped with
<main>
or section, if you think about = the cards you can replace the<div>
that’s wrapping each card with<article>
you can wrap the paragraph with the quote with the tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation. Note that<div>
is only a block element without meaning, prefer to use it for small blocks of content inside bigger blocks wrapped with some better markup.Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp
✌️ I hope this helps you and happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord