
Design comparison
Community feedback
- @Isa696Posted 3 months ago
Great work! I noticed you used grid-column-start and grid-column-end instead of grid-column: 1 / 3; and grid-row: 1 / 2;. Both approaches work the same, but the second one is a bit more concise. However, your way can be more readable, so it really comes down to personal preference.
Here’s a small suggestion: you could centralize your color variables by defining them in the :root like this:
css Copiar código :root { --Moderate-violet: hsl(263, 55%, 52%); --Very-dark-grayish-blue: hsl(217, 19%, 35%); --Very-dark-blackish-blue: hsl(219, 29%, 14%); --White: hsl(0, 0%, 100%); --Light-gray: hsl(0, 0%, 81%); --Light-grayish-blue: hsl(210, 46%, 95%); } Then you can reuse them as var(--color-name) in your CSS. It helps keep the code more maintainable and scalable. What do you think? 😃"
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord