Skip to content
Submitted 3 months ago

Testimonials Section Grid solution

Robel T. Hawelti•100
@Rapbit27
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Testimonials grid section
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

My understanding of css grid is even better with this challenge. Positioning the cards accordingly was quite satisfying.

What specific areas of your project would you like help with?

Please check out my code and give me feedback on how to better setup the grid.

Community feedback

  • Darkstar•1,100
    @DarkstarXDDPosted 3 months ago

    Looks good. Couple of suggestions.

    • I don't think the verification status are headings. Definitely not <h1>s. You should only have one <h1> heading for a page, which will be the primary text that explains the content of the page. It's better to have the user status as <p> elements.
    • I would always use rem when specifying the max-width and avoid using percentage values for max-width.
    • Is there a need for the grid-auto-rows: minmax(10rem, auto)?
    Marked as helpful
    0
    Robel T. Hawelti•100
    @Rapbit27Posted 3 months ago

    @DarkstarXDD Thanks for the feedback!! I'll make sure to apply them in future projects too.

    • As for the grid-auto-rows: minmax(10rem, auto) it was there when I was experimenting with the grid and forgot to remove it at the end.
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord