Testimonials Page (Js , Css) 🥗

Community feedback

• 

  Tryt4n•960

  @Tryt4nPosted over 1 year ago

  Your path for ::before pseudo element in blockquote is wrong. Personally I think it would be better use ::before or ::after on your person img instead of adding another img element which has only a decorative function.

  Also would be better if you would add your buttons in img section. Would be easier to place them. Currently they always have different placement. Instead of that it they would be in img container you could position them absolutely to that container then add bottom: 0; left: 0; and translate: 100% 50%; and it would be exactly the same as in the project.

  Also because you use top and left on your buttons container with such a massive number (40rem and 60rem) it's completely mess with your media query. Below 1100px your buttons overlapping your body.

  Your media query for mobile should start below around 1024px in my opinion. Even when I disabled 60rem for left for your buttons the img element is getting started to be very small.

  And some typo:

  • your both buttons have the same aria-label

  Marked as helpful

  1
• 

  FETYagency•1,280

  @FETYagencyPosted over 1 year ago

  hey brother i swear it is a nice attempt and here is some points that i think will improve your design

  • make that button positioned relatively to the viewport instead the inline_start of the wrapper container because it will cause you an overflow.
  • you can wrap all the images in one container and attach their sizes to the inline size of the container to make them look like a united item.(you can use the container query, the "cqi" unit to achieve that and rely on the inline-size property powered by the clamp function and set the flex-basis to "auto" if you are using the flex blox).
  • never forget to use the max-inline-size property to avoid your design getting over-expanded
  • use several media queries with specific text styles so to avoid that creepy shrinks and breaks in your text (it is very important when your are working with a brand that want to establish its identity in the users brain).

  Marked as helpful

  1