Design comparison
SolutionDesign
Solution retrospective
any suggestions for improvement would be greatly appreciated!
Community feedback
- @VCaramesPosted about 2 years ago
Hey, great job on this project!
Some suggestions to improve you code:
- For each individual testimonial quote, its semantically better to use the <blockquote> element. The <blockquote> HTML element indicates that the enclosed text is an extended quotation.
More info: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote
- For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
Happy Coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord