Skip to content
Submitted over 2 years ago

testimonials layout using grid and flexbox property

Ketan_2000•180
@ketannegi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Testimonials grid section
  • HTML
  • CSS
2junior

Design comparison

SolutionDesign

Solution retrospective

I'd love to hear your lovely feedback.😊😊

Community feedback

  • Damilola Olanrewaju•310
    @Dami-MoorePosted over 2 years ago

    Hi @katannegi! Great attempt. The site is quite responsive.

    I have a few comments for your html code.

    It's not semantically right to have multiple headers. So, in this challenge, since there isn't like a main header, it can be left out. Instead, you can contain each section (box) within a <section> tag, then within each <section>, wrap each segment in a <div> and then wrap the whole code after the <body> tag with a <main> tag.

    The attribution section can be wrapped in a <footer> tag instead of using a <div>.

    This will greatly improve accessibility.

    I hope this was helpful! Happy coding!

    0
    Ketan_2000•180
    @ketannegiPosted over 2 years ago

    @Dami-Moore thanks bro.. I'm focusing on making layour but didn't realise about Semantics tags.... . Thanks for feedback ☺

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord