Design comparison
SolutionDesign
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- To properly center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here 📚.
- For this demonstration we use css
Grid
to center the component.
body { min-height: 100vh; display: grid; place-items: center; }
- Now remove these styles, after removing you can able to see the changes
#testimonial-grid-container { padding: 5% 3%; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - @KhawarmehfoozPosted over 1 year ago
Hi! 👋 Congratulations on completing the challenge!
I have some suggestions to improve the solution:
- Add the following CSS properties to the
testimonial-grid-container
to properly resize and center the container:
width: min(75%, 70rem); margin-inline: auto;
- Instead of using a media rule with a min-width of 576px and a max-width of 1440px for the container, consider using the property mentioned in the previous point. It will handle all the responsiveness more effectively.
Happy coding!
Marked as helpful1 - Add the following CSS properties to the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord