Design comparison
Solution retrospective
So, this is the first time I've ever used CSS grid on my own. It may not be my best work when I submit this. Are there better practices that I could have implemented on the grid? Also, I have a feeling when I submit this, it's going to be too large. If thats the case, how should I set the size of this grid?
Community feedback
- @BenjaDotMinPosted almost 3 years ago
Hello there!
You really do have a great grasp with grid, for your first attempt. Much better than I did!
However, regarding your question:
- To your body tag add: height:100vh; display: grid; place-items: center;
- To your main tag add: max-width: 1440px;
That should improve the size and positions. You can play around with values to match what you need.
It wont make a difference, but consider the shorthand syntax for grid-template, to save yourself repeating values and make it easier to read.
For example: grid-template-columns: 1fr 1fr 1fr 1fr; grid-template-rows: 1fr 1fr;
Could simply become: grid-template: repeat(2, 1fr) / repeat(4, 1fr);
Marked as helpful1@Mattvp21Posted almost 3 years ago@BenjaDotMin Ahhh! I was wondering why justify content didn’t work! Thanks
1 - @brodiewebdtPosted almost 3 years ago
Kevin Powell did a video on CSS Grid using this challenge. You might pick up some tips for that. https://www.youtube.com/watch?v=rg7Fvvl3taU
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord