Design comparison
SolutionDesign
Solution retrospective
Waiting for Feedback!
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi there! 👋
Nice work on this challenge! 👍
There are some areas that can be improved.
- I suggest adding a
max-width
to thecontainer
to prevent the cards from becoming too large at screen size below1200px
. In my opinion, a700px
max-width would be good enough. - For the quote, I recommend wrapping the
p
element withblockquote
for better semantic HTML. - My final suggestion is to write the styling using the mobile-first approach. It often leads to shorter and better performance code. Also, mobile users won't be required to process all of the desktop styles.
That's it! Hope this helps.
Marked as helpful1@obaidash99Posted over 2 years agoThank you a lot sir! @vanzasetia
I will start using the mobile-first approach soon, I'm just getting started with coding on my own and your comments are a huge help!
Waiting for your opinions about my future projects!
0 - I suggest adding a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord