Design comparison
Solution retrospective
My first project made with Svelte. I had a lot of fun building this project. Any feedback is very welcome.
Community feedback
- @correlucasPosted over 2 years ago
👾Sdravo Tjaša, congratulations for your solution!
Your solution is just perfect, you've add almost everything, the grid layout is perfect desktop and mobile. The media query is correct. You did pretty much anything, there's only few details you can improve.
1.There's a colored border in the profile photo for the purple and black card.
border: 4px solid cyan;
2.The component isn't fully aligned and miss a border to avoid that the cards touch the screen bound when the screen scales down in the mobile version. I've add the code fixes below:
body { display: flex; align-items: center; } main { margin: 24px; }
3.Instead of wrapping all the cards with a div, you can use a semantic tag for this as <section> or <article>
Anyway, congrats this is a really beautiful and well done solution Tjaša.
Happy coding!
Marked as helpful0@TjasaZilPosted over 2 years ago@correlucas Thank you soo much Lucas! I will make the changes as soon as I sit behind the computer again. Have a nice day!
1@correlucasPosted over 2 years ago@zuzexx You're welcome Tjaša, have a nice day too 😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord