Design comparison
SolutionDesign
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hi there ๐. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
HTML:
- The image with the testimonial author is not a decoration, you need to provide an alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the
alt
attribute value. e.g.alt="Daniel Clifford"
If you want to learn more about the
alt
attribute, you can read this article.- To improve the semantics of your code you should use the
<figure>
and<blockquote>
tags to wrap the testimonials, with this, you will be able to encapsulate the author and the citation of the testimonial.
Example:
<figure> <blockquote> <p>"Example of a testimonial"</p> </blockquote> <figcaption> <p>Example of the author</p> </figcaption> </figure>
You can read more about the
<figure>
and<blockquote>
tags with this two links:- You should use only one
<h1>
tag per page. The<h1>
tag is the most important heading tag, This can confuse screen reader users and search engines.
CSS:
- Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:
Credit to grace-snow and vanzasetia for pointing this out.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding! ๐
Marked as helpful0 - The image with the testimonial author is not a decoration, you need to provide an alternative text to tell the user who is the author of the testimonial, its recommended to use the author's name as the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord