Testimonials-grid-section

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The styling still needs a lot of work to look like the FEM design.

  • To improve the semantics of your component, you will want to wrap each individual testimonial component in a figure element, the individuals information should be wrapped in a figcaption element and lastly, the testimonial itself should be wrapped in a blockquote element.

  Code:

  <figure>
     <figcaption></figcaption>
     <blockquote></blockquote>
  </figure>
  

  More Info:📚

  MDN Figure Element

  • The only headings in this component are the names of each individual; “Daniel Clifford”, “Jonathan Walters”, “Jeanette Harmon”, “Patrick Abrams” and “Kira Whittle”. Everything else should be wrapped in a paragraph element.

  • The profile images are not decorative. Their alt tag should not be blank. It should state the following; “Headshot of -person’s full name-“

  More Info:📚

  Headshot Alt Text

  • Your content is not fully responsive. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:

  https://web.dev/learn/design/

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  1

  ---

  

  nuket•60

  @nukettasPosted almost 2 years ago

  Hello @vcarames 🤚 *Thank you so much for this feedback. For the next challenge I will make sure that I use headings properly.

  • I will check the MDN for the figure element, I haven’t use that element before. thank you for the detailed explanation with code on that part.
  • I’ve tried to make it responsive as much as possible but I think I should study that part more.

  Thank you so much again.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @nukettas

  Glad I could help!☃️

  Keep it up!

  0
• 

  faizan•2,420

  @afaiz-spacePosted almost 2 years ago

  Hey @nukettas, congratulations on completing the challenge.

  • instead of using the top left property use the grid property then you will get a better result.
  • also make a responsive website. Must have a mobile-first approach.

  1

  ---

  

  nuket•60

  @nukettasPosted almost 2 years ago

  Hello @afaiz-space Thank you so much for the feedback 🙂

  0