Testimonials grid section with SASS/BEM

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Felix Anducho! 👋

  Like artimys said, wonderful job on this challenge! Your solution looks good and responds very nicely! 👏

  I only suggest adding a subtle box-shadow around the testimonial cards (as in the original design). 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Felix Anducho•400

  @PleopleqPosted almost 4 years ago

  Thanks @ApplePieGiraffe

  Woops i totally forgot about the shadow haha ill fix it in a sec.

  Have a great day!

  0
• 

  Arturo Simon•1,785

  @artimysPosted about 4 years ago

  Hey Felix, amazing job with this challenge. Your design responds really well. I looked through your HTML and CSS and it's solid. Good use of semantics and good practice of using BEM. It doesn't really matter but I would use <h2> instead of <h3> for your quote-user__username just because h2 is the first in line for article and h2 isn't being used anywhere.

  Great job and Happy coding 👍👍

  side note: page title missing from document

  1

  ---

  

  Felix Anducho•400

  @PleopleqPosted almost 4 years ago

  Thanks a lot @artimys i actually didnt remember how grid works and i took a look at your solution haha.

  0