Testimonials grid section with html and CSS Grid.
Design comparison
Solution retrospective
Hi guys!! I'm back after 3 days :D Any feedback would be really appreciated!!
Community feedback
- @gacburPosted almost 4 years ago
Wow... this is awesome, keep it up :) great work.
1@AbbasSaad27Posted almost 4 years ago@gacbur Thanks a lot for the feedback mate!! Happy coding! :D
0 - @ApplePieGiraffePosted almost 4 years ago
Hey, Abbas Saad! 👋
Nice job on this challenge! 👏 As the others have said, everything looks pretty great and your solution responds well! 👍
I only suggest not adding
cursor: pointer
to the testimonial cards since they are not clickable elements and might make the UX a little confusing (the hover state is cool, though). 😉Also, you might be able to use the
<article>
tag for the testimonial cards to make your HTML a wee bit more semantic!As always, keep coding (and happy coding, too)! 😁
1@AbbasSaad27Posted almost 4 years ago@ApplePieGiraffe Thanks a lot for the feedback! Now that you say it, I also think that the pointer cursor was unnecessary. I'll remove that asap. Thanks for pointing that out!! :D I totally forgot about the article tag sorry :') I'll keep it in mind the next time. Thanks for the suggestions!! Happy coding! :D
1@ApplePieGiraffePosted almost 4 years ago@AbbasSaad27
Haha, no problem! We're always learning and it's great to see how excited you are! Keep it up! 👍
1@AbbasSaad27Posted almost 4 years ago@ApplePieGiraffe Thanks again!! I'll definitely try to keep it up!! :D
0 - @MasterDev333Posted almost 4 years ago
Great work @Abbas Saad. Your solution is spot on. Fully responsive and close to design. Especially, I love your card hover effect. :) "Perfect!" Look forward to seeing other solutions from you. Happy coding~ :)
1@AbbasSaad27Posted almost 4 years ago@MasterDev333 Thanks a lot for the feedback!! I'm glad that you like it! Thanks again! It helps to lift up my spirits!! :D Happy coding! :D
0 - @axevldkPosted almost 4 years ago
Hi, @Abbas Saad ~ I have studied your work, and it's really great. The only thing I can recommend is trying to use BEM naming convention. Nothing to say. Great! ✨
1@AbbasSaad27Posted almost 4 years ago@axevldk Thanks a lot for the feedback!! :D I'm actually really bad at naming things :') I'll look try learning BEM naming convention ASAP. Thanks for the suggestion!! :D Happy coding!!
1 - @abhik-bPosted almost 4 years ago
Hey Abbas, Great job on this challenge 👌. I really like those hover transitions and overall solution. Keep it up 💯
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord