Testimonials grid section with CSS Grid

Community feedback

• 

  yuenu•505

  @yuenuPosted about 3 years ago

  Hi, @Take

  Nice work, it looks pretty good but there's a suggestion that would make the layout look better

  • On mobile, on className testimonials you can changing your grid-template-rows property to minmax , you don't defined the rows by yourself

  And I would add .testimonial padding-bottom

  .testimonials {
    grid-template-rows:  minmax(0, auto);
  }
  
  .testimonial {
    padding: 2.6rem 3.2rem 2.6rem 3.2rem;
  }
  

  0

  ---

  

  Take•400

  @ttakeyayaPosted about 3 years ago

  @yuenu

  Thank you for your comment. Your idea would improve the site. I'll tweak the points you mentioned.

  0
• 

  Muhammad Shajjar•1,100

  @muhammadshajjarPosted about 3 years ago

  Hi Take, Nice work on this one some suggestions would help you

  • Try to add max-width to your body or make a container class that wraps your all content, by adding it you can control your content from growing too much on larger viewports
  • To overcome your accessibility issue you would need to add some semantic markers to designate sections of the page as the header, navigation, main content, and footer e.g:

  <main>
  <section> 
  </section>
  </main>
  <footer>
  <div class="attribute"></div>
  </footer>
  

  • Page should contain one 'h1'
  • Use bloclquotes for quotes instead of using p

  0

  ---

  

  Take•400

  @ttakeyayaPosted about 3 years ago

  @muhammadshajjar

  Thank you for your suggestions! I'll fix those.

  0