Design comparison
Solution retrospective
I know I'm not providing exactly the same view, but I think I'm providing a similar view. I'm not sure if I'm using svg correctly. Waiting for your suggestions. I would appreciate if you point out the wrong or missing parts.
Community feedback
- @correlucasPosted over 2 years ago
Hello Erenseven, congratulations for your solution, I've done this same challenge so I know its tricky to setup this grid. You've done a good work there.
There's only some tiny details to adjust to get closer as possible, I'll list you the details I saw:
1.The
padding
for each card should be uniform, note that the second card (the gray one) isn't fully aligned center in comparison to the others.My advice is that you apply one general class for all the cards and do the other changes with a specific class for the other cards (like the purple and the black one). Setting a single
padding
for this general class for.card
will save you time applying changes.2.The
gap
inside thegrid
, note that is a really tiny detail, but I know that only because I did this adjustment to mine, thegrid-row
has a different value in comparison of thegrid-column
so if you usegap
will not work since the gap value isn't equal for both.The value for the row-gap is:
row-gap: 24px;
The value for the column-gap is:
column-gap: 30px;
3.The border around the profile image goes only to two cards, the purple and the black card, again, this is another tiny detail, but if you want to match the design file, is something you might change creating a class and applying inside the img for both cards.
Overall you did all the challenge requires and reach the solution purpose. I hope this few advices help you in some way.
Happy coding Erenseven!
Marked as helpful1@ErenSevenPosted over 2 years ago@correlucas Thank you for the feedback. I forgot to change the color of the border of the profile photos. I didn't realize I had to give the gaps separately thank you
1@correlucasPosted over 2 years ago@ErenSeven hey, you're welcome, happy to hear this helps you.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord