Testimonials grid section | css grid

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful! 😊

  First of all, what do you mean by "my elements seem to overflow their main container, why is that?". What are YOUR ELEMENTS?

  To fix the height issue instead of writing height: 100% for the body change it to min-height: 100vh.

  html {
      height: 100%;
  }
  body {
      min-height: 100%;
  }
  

  This allows the HTML element to reference the parent viewport and have a height value equal to 100% of the viewport value. With the HTML element receiving a height value, the min-height value assigned to the body element gives it an initial height that matches the HTML element.

  Try to use sections instead of just divs, div has no semantic meaning and semantics is actually a very useful thing for accessibility.

  I also see you don’t have README. README is a very important aspect of making projects, especially if you want other people to see it. As the name says, it’s the first thing people read when interacting with the project, it is kind of a manual. You can include many things there like the languages you used, which dependencies you installed, what was the process like, and what did you achieve or learn. Frontend Mentor also has a pretty nice README template which you can use to tailor the one depending on your preferences.

  Marked as helpful

  0

  ---

  

  vabel17•120

  @vabel17Posted almost 2 years ago

  @catherineisonline By "elements" I meant to say my cards haha, your solution helps though, thank you!

  0