Testimonials Grid Section using HTML, CSS, Grid, Flexbox, Media Query

Community feedback

• 

  darryncodes•6,390

  @darryncodesPosted almost 3 years ago

  Hi Genesis,

  Great work with grid here, well done!

  I'd encourage you to clear down your accessibility report. Swap <div class="container"> with <main class="container"> and <div class="attribution"> with <footer class="attribution">. You could consider using <section> and headings in this challenge. Using the most descriptive html for the job is really important and the correct heading structure

  You could consider including a screen reader only <h1>, this snippet will help you do it:

  .sr-only {
    position: absolute;
    width: 1px;
    height: 1px;
    padding: 0;
    margin: -1px;
    overflow: hidden;
    clip: rect(0, 0, 0, 0);
    white-space: nowrap;
    border: 0;
  }
  

  Marked as helpful

  1

  ---

  

  Genesis Gran•270

  @GenesisGranPosted almost 3 years ago

  @darryncodes Thanks for the feedback. I always wonder how I can remove those accessibility issues and now I know. Thanks for the snippet too, I will use that for my next project.

  0

  

  darryncodes•6,390

  @darryncodesPosted almost 3 years ago

  You're welcome @GenesisGran, don't forget to refresh the report after too!

  0